build-tools/fab/changes/260406-vhk4-migrate-workflows-github-actions/checklist.md

Quality Checklist: Migrate Workflows to GitHub Actions

Change: 260406-vhk4-migrate-workflows-github-actions Generated: 2026-04-06 Spec: spec.md

Functional Completeness

• CHK-001 Archive: 4 non-GCP files exist in .github/workflows/archive/
• CHK-002 Archive: 4 non-GCP files no longer exist in .github/workflows/
• CHK-003 Rename: 4 GCP files renamed without -gcp suffix
• CHK-004 Rename: No -gcp.yml files remain in .github/workflows/
• CHK-005 S3 fix: push-s3.yml uses aws-actions/configure-aws-credentials@v4
• CHK-006 S3 fix: push-s3.yml uses inline aws s3 cp command (no external action)

Behavioral Correctness

• CHK-007 GCP auth steps identical in all 4 renamed workflows (auth@v2, setup-gcloud@v2, configure-docker)
• CHK-008 All runners are ubuntu-22.04
• CHK-009 Grype scanning remains commented out in all workflows
• CHK-010 AWS secret/var names are uppercase: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_DEFAULT_REGION, AWS_UPLOAD_BUCKET
• CHK-011 S3 upload preserves all flags: --recursive, --cache-control max-age=31536000, --storage-class STANDARD_IA

Scenario Coverage

• CHK-012 Archive directory exists with correct files
• CHK-013 S3 destination path matches pattern: s3://{bucket}/{repo_short_name}/{build_id}

Code Quality

• CHK-014 Pattern consistency: Workflow YAML follows existing naming and structural patterns
• CHK-015 No unnecessary duplication: No Gitea-specific references remain in active workflows

Notes

• Check items as you review: - [x]
• All items must pass before /fab-continue (hydrate)
• If an item is not applicable, mark checked and prefix with N/A: - [x] CHK-008 **N/A**: {reason}