build-tools/fab/project/code-review.md

Code Review

Severity Definitions

• Must-fix: Spec mismatches, failing tests, checklist violations — always addressed during rework
• Should-fix: Code quality issues, pattern inconsistencies — addressed when clear and low-effort
• Nice-to-have: Style suggestions, minor improvements — may be skipped

Review Scope

• Changed files only (files touched during apply)
• Skip generated code and vendor directories
• Skip binary files and assets

False Positive Policy

• Inline <!-- review-ignore: {reason} --> in markdown files
• Inline // review-ignore: {reason} or # review-ignore: {reason} in code files
• Suppressed findings are noted in the review report but not counted as failures

Rework Budget

• Max cycles: 3
• After 2 consecutive "fix code" attempts on the same issue, escalate to "revise tasks" or "revise spec"

Project-Specific Review Rules